Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPT-1998 Swift cuncurrency support #122

Merged
merged 9 commits into from
Apr 16, 2024

Conversation

mrandrewsmith
Copy link
Collaborator

Добавлена поддержка Swift Concurrency.

Созданы новые протоколы:

  • AsyncNode - нода, которая умеет ассинхронно выполнять обработку данных и возвращает результат.
  • AsyncStreamNode - нода, которая умеет ассинхронно выполнять обработку данных и превращает результат в асинхронный поток.

Поправлены тесты для прохождения ci. Основные работы по тестам будут в следующих ПР.

@mrandrewsmith mrandrewsmith self-assigned this Mar 26, 2024
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-swift-cuncurrency-support branch from 15513ec to 85c91ed Compare March 26, 2024 14:35
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-swift-cuncurrency-support branch from 85c91ed to 45008c3 Compare March 26, 2024 14:38
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-swift-cuncurrency-support branch from 45008c3 to 74883a8 Compare March 26, 2024 15:01
Copy link
Contributor

@NullIsOne NullIsOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Несколько замечаний по тестам (в основном некритичные) и много опечаток в доке (возможно не все нашел)

NodeKit/Core/Node/NodeResult.swift Outdated Show resolved Hide resolved
NodeKit/Utils/Logging/LoggerNode.swift Outdated Show resolved Hide resolved
NodeKit/Layers/Utils/AccessSafe/TokenRefresherNode.swift Outdated Show resolved Hide resolved
NodeKit/Layers/InputProcessingLayer/DTOEncoderNode.swift Outdated Show resolved Hide resolved
NodeKit/Layers/DTOProcessingLayer/RawEncoderNode.swift Outdated Show resolved Hide resolved
NodeKit/Core/Node/NodeResult.swift Outdated Show resolved Hide resolved
@mrandrewsmith mrandrewsmith requested a review from NullIsOne March 27, 2024 11:04
Copy link
Contributor

@chausovSurfStudio chausovSurfStudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тесты не глядел, потому уже с другими тестами гляну

не помню, было ли что-то критичное в комментах, кажется как будто если где-то и были неточности - ты тестами потом найдешь) так что если ничего критичного и работа будет блочиться - можешь мержить

NodeKit/Core/Node/Node.swift Show resolved Hide resolved
NodeKit/Core/Node/NodeResult.swift Outdated Show resolved Hide resolved
NodeKit/Core/Node/NodeResult.swift Outdated Show resolved Hide resolved
NodeKit/CacheNode/ETag/UrlETagSaverNode.swift Outdated Show resolved Hide resolved
NodeKit/CacheNode/ETag/UrlETagSaverNode.swift Show resolved Hide resolved
request: urlRequest,
response: urlResponse,
data: value,
metrics: nil, // ?? почему nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тоже интересно стало))

@mrandrewsmith mrandrewsmith changed the base branch from SPT-1998-logger to 5.0.0 April 16, 2024 10:22
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-swift-cuncurrency-support branch from cf47973 to d3ae0e1 Compare April 16, 2024 11:47
@mrandrewsmith mrandrewsmith merged commit 3673334 into 5.0.0 Apr 16, 2024
1 check passed
@mrandrewsmith mrandrewsmith deleted the SPT-1998-swift-cuncurrency-support branch May 7, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants